Transitioning password should not set password_changed? true #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:test_callback, unless: :password_changed?
tiegz
reviewed
Nov 25, 2020
Comment on lines
+96
to
+109
| User.class_eval do | ||
| after_update :verify_not_changed, unless: :password_changed? | ||
| def verify_not_changed; end | ||
| end | ||
| ben = users(:ben) | ||
| mock_method = MiniTest::Mock.new | ||
| mock_method.expect :call, nil | ||
| ben.stub :verify_not_changed, mock_method do | ||
| transition_password_to(Authlogic::CryptoProviders::BCrypt, ben) | ||
| end | ||
| mock_method.verify | ||
| User.class_eval do | ||
| User.skip_callback :update, :after, :verify_not_changed | ||
| end |
There was a problem hiding this comment.
Would something simpler work too, vs using callbacks? I don't think the record would get reloaded, so we could do e.g.
ben = transition_password_to(Authlogic::CryptoProviders::BCrypt, users(:ben)).first
refute ben.send(:password_changed?)`Or, maybe we should just move this assertion into transition_password_to?
|
Bump on this @pduey , I'd be interested by this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a password is being transitioned to a new crypto provider, I would expect
password_changed?to be falsey, but it is true. This draft PR adds a test to demonstrate it. If you change the definition oftransition_passwordas follows, the test will pass:In password= @password_changed is set to true, so this just inverts that. Other possible solutions I've thought of: